Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16784 )
Change subject: [thirdparty] Upgrade Protobuf to 3.14.0 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG@7 PS1, Line 7: Upgrade Protobuf > BTW, do you plan to update protobuf version used in Java part of the projec Yeah, I will bump the Java versions in bulk at some point per the usual "[Java] Upgrade Dependencies" commit. http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG@9 PS1, Line 9: This patch upgrades Protobuf from 3.12.3 to 3.14.0 > Does it make sense to add more colors about the motivation for this version I am hopeful this bump will fix the UBSAN issue I was seeing in the C++17 patch, but even if it doesn't we can/should merge it. For that reason, I left it out of this message. -- To view, visit http://gerrit.cloudera.org:8080/16784 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae Gerrit-Change-Number: 16784 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 25 Nov 2020 17:43:34 +0000 Gerrit-HasComments: Yes
