Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16596 )
Change subject: [partitioning] KUDU-2671: Support for range specific HashSchemas. ...................................................................... Patch Set 11: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/16596/11/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/16596/11/src/kudu/common/partition-test.cc@1073 PS11, Line 1073: range_hash_schemas.emplace_back(PartitionSchema::HashBucketSchemas()); Is this important? If not, maybe remove it? Seems like it shouldn't be since we didn't clear 'range_hash_schemas'. http://gerrit.cloudera.org:8080/#/c/16596/11/src/kudu/common/partition.h File src/kudu/common/partition.h: http://gerrit.cloudera.org:8080/#/c/16596/11/src/kudu/common/partition.h@413 PS11, Line 413: encoded_bounds nit: can you update this? http://gerrit.cloudera.org:8080/#/c/16596/11/src/kudu/common/partition.h@416 PS11, Line 416: range_hash_schemas nit: can you also document how this is used, what to expect if it's empty, etc? http://gerrit.cloudera.org:8080/#/c/16596/11/src/kudu/common/partition.h@420 PS11, Line 420: // Splits the encoded range bounds by the split points. The splits and bounds : // must be sorted. If `bounds` is empty, then a single unbounded range is : // assumed. If any of the splits falls outside of the bounds then an : // InvalidArgument status is returned. nit: can you update this? -- To view, visit http://gerrit.cloudera.org:8080/16596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8725f4bd072a81b05b36dfc7df0c074c172b4ce8 Gerrit-Change-Number: 16596 Gerrit-PatchSet: 11 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 30 Nov 2020 20:47:36 +0000 Gerrit-HasComments: Yes
