Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16806 )
Change subject: [build-support] devtoolset-8 allows to build on CentOS 6 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh@20 PS1, Line 20: # Enables the Red Hat devtoolset and executes the arguments on RHEL-based : # systems where the default C++ compiler does not support all features : # necessary to compile Kudu from source (C++17). On other (newer) RHEL-based : # systems and non-RHEL systems, the arguments are e > Not this change but since you are here, it'd be good to update the comments Done http://gerrit.cloudera.org:8080/#/c/16806/1/build-support/enable_devtoolset.sh@20 PS1, Line 20: # Enables the Red Hat devtoolset and executes the arguments on RHEL-based : # systems where the default C++ compiler does not support all features : # necessary to compile Kudu from source (C++17). On other (newer) RHEL-based : # systems and non-RHEL systems, the arguments are e > Good catch Done -- To view, visit http://gerrit.cloudera.org:8080/16806 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15f58edd090243ceb07a46f92d44e9998747ec5e Gerrit-Change-Number: 16806 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Dec 2020 03:54:15 +0000 Gerrit-HasComments: Yes
