Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc File src/kudu/clock/test/mini_chronyd.cc: http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc@424 PS1, Line 424: // TODO(aserbin): use some synthetic mount point instead? > This TODO can now be removed. nit: I'd prefer this TODO to stay. Ideally, all test-related files should be under the test directory, and this TODO is about making it possible. As of now, the sub-dir would not be removed if test fails and the socket is left there, polluting /tmp -- To view, visit http://gerrit.cloudera.org:8080/16812 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e Gerrit-Change-Number: 16812 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 02 Dec 2020 19:05:13 +0000 Gerrit-HasComments: Yes
