Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16818 )
Change subject: [TxnStatusManagerTest] fix replica restart in GetTransactionStatus ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Thanks for finding and fixing this! http://gerrit.cloudera.org:8080/#/c/16818/1/src/kudu/transactions/txn_status_manager-test.cc File src/kudu/transactions/txn_status_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/16818/1/src/kudu/transactions/txn_status_manager-test.cc@474 PS1, Line 474: { : ASSERT_OK(RestartReplica()); : decltype(txn_manager_) txn_manager_reloaded( : new TxnStatusManager(tablet_replica_.get())); : ASSERT_OK(txn_manager_reloaded->LoadFromTablet()); : txn_manager_ = std::move(txn_manager_reloaded); : } At first, I thought it might be worth encapsulating this in some RestartReplicaAndReload(), but it seems that elsewhere, RestartReplica() calls are followed by the creation of separate status manager instances rather than using txn_manager_, so it probably wouldn't be useful with the current set of tests beyond this one. -- To view, visit http://gerrit.cloudera.org:8080/16818 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I62f86cfc686a121a1689e6f3942aa4050406ffe2 Gerrit-Change-Number: 16818 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 03 Dec 2020 20:25:59 +0000 Gerrit-HasComments: Yes
