Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16814 )
Change subject: [tserver] KUDU-2612: participant op RPC endpoint ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/16814/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16814/1//COMMIT_MSG@9 PS1, Line 9: This adds an RPC endpoint to the tablet servers that allows proxies to : interact with transaction participants. > Could you add more colors on this, adding an example of a scenario when and Done http://gerrit.cloudera.org:8080/#/c/16814/1/src/kudu/integration-tests/txn_participant-itest.cc File src/kudu/integration-tests/txn_participant-itest.cc: http://gerrit.cloudera.org:8080/#/c/16814/1/src/kudu/integration-tests/txn_participant-itest.cc@521 PS1, Line 521: not RUNNING > BTW, what is the expected behavior what a tablet is bootstrapping? Is it t It's the same. Added a test. http://gerrit.cloudera.org:8080/#/c/16814/1/src/kudu/integration-tests/txn_participant-itest.cc@529 PS1, Line 529: dummy-tablet-id > BTW, would we allow status tablet to participate in a transaction? Not sur I don't think it's out of the question, especially since the base functionality of transactions doesn't rely on transactions, so there is no chicken/egg bootstrapping problem there. http://gerrit.cloudera.org:8080/#/c/16814/1/src/kudu/tserver/tserver_admin.proto File src/kudu/tserver/tserver_admin.proto: http://gerrit.cloudera.org:8080/#/c/16814/1/src/kudu/tserver/tserver_admin.proto@113 PS1, Line 113: message ParticipantRequestPB { : optional bytes tablet_id = 1; : optional ParticipantOpPB op = 2; : } > Just want to double-check it's safe to swap the fields. I guess it's so be Yeah, these aren't used at all in previous versions. Even if they were, I think it's acceptable to do these breaking changes provided the feature is experimental (and even incomplete in 1.13). http://gerrit.cloudera.org:8080/#/c/16814/1/src/kudu/tserver/tserver_admin.proto@256 PS1, Line 256: Have a tablet participate in a transaction > It would nice if the comment were a bit more clearer w.r.t. what is the sem Done -- To view, visit http://gerrit.cloudera.org:8080/16814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48895438ce67e453d235934ac560efe8415921b Gerrit-Change-Number: 16814 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Dec 2020 02:28:30 +0000 Gerrit-HasComments: Yes
