Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16815 )
Change subject: [txn] update not-a-leader retry logic in TxnSystemClient ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc File src/kudu/transactions/coordinator_rpc.cc: http://gerrit.cloudera.org:8080/#/c/16815/2/src/kudu/transactions/coordinator_rpc.cc@188 PS2, Line 188: if (result.status.IsAborted()) { > I guess that was supposed to be handled in the code below with TabletServer Right, I am running into similar issues on the TxnParticipant side. I think one approach would be to unwrap resp.error().code() early, selecting an appropriate result as below, and if not, then check the error status, the observation being that error codes are much more fine-grained than Statuses. E.g. for the TxnStatusManager, in addition to returning IllegalState(), we could set ts_error to TXN_ILLEGAL_STATE. -- To view, visit http://gerrit.cloudera.org:8080/16815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b8abb27c7678c5c616a325343620902f6cbfd59 Gerrit-Change-Number: 16815 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Dec 2020 03:22:47 +0000 Gerrit-HasComments: Yes
