Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16853 )
Change subject: [thirpdarty] Improve LLVM build for macOS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/16853/1/thirdparty/build-definitions.sh@a348 PS1, Line 348: > I didn't understand removal of this line. It's not needed anymore. The previous issue we saw was a result of multiple aarch64 targets, but the above change to remove the various simulators is a permanent fix. We can now revert back to letting the architectures be dictated by the host. -- To view, visit http://gerrit.cloudera.org:8080/16853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45c60cd2da120906c436b5592ad6b9e6a89dde66 Gerrit-Change-Number: 16853 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 10 Dec 2020 18:11:14 +0000 Gerrit-HasComments: Yes
