Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16852 )
Change subject: Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK ...................................................................... Improve preadv/pwritev with Xcode 12 and the OSX 11 SDK This is a follow on to 0e2c288 which introduced version checks to handle the introduction of preadv/pwritev in the OSX 11 SDK. Instead of using a compile time macro to disable using the preadv/pwritev simulations, this patch reverts to using them all the time and adjusts the naming of the method to ensure there are no symbol issues. This is important so that a binary compiled using the OSX 11 SDK can run on a machine running OSX < 11. This scenario will frequently occur on Xcode 12 given the OSX 11 SDK is installed by default and chosen by default by CMake even though the machine is running OSX 10. Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Reviewed-on: http://gerrit.cloudera.org:8080/16852 Tested-by: Kudu Jenkins Reviewed-by: Bankim Bhavsar <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/util/env_posix.cc 1 file changed, 12 insertions(+), 7 deletions(-) Approvals: Kudu Jenkins: Verified Bankim Bhavsar: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I90ba8f65b756c77c25dc776d0174b0d7b5678137 Gerrit-Change-Number: 16852 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
