Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16867 )
Change subject: [client] small cleanup on AsyncRandomTxnManagerRpc ...................................................................... [client] small cleanup on AsyncRandomTxnManagerRpc This patch changes AsyncRandomTxnManagerRpc so it owns the request protobuf message. The rationale: there is no need to keep a pointer because the request message is no longer needed at the call sites once it's populated and passed to the AsyncRandomTxnManagerRpc's constructor. I also modified the call sites accordingly to use move semantics for the corresponding argument while calling the constructor. This patch does not contain any functional changes. Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f Reviewed-on: http://gerrit.cloudera.org:8080/16867 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/client/transaction-internal.cc M src/kudu/client/txn_manager_proxy_rpc.cc M src/kudu/client/txn_manager_proxy_rpc.h 3 files changed, 70 insertions(+), 62 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/16867 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ide5b96644832bbcd2c3b08e72aee49f993ddb95f Gerrit-Change-Number: 16867 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
