Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16876 )
Change subject: rpc: fix non-retriable error when starting up or shutting down ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/rpc/messenger.cc@382 PS1, Line 382: Status::ServiceUnavailable > Now, when there is more detailed information on the state of the messenger, Done http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/server/rpc_server.cc File src/kudu/server/rpc_server.cc: http://gerrit.cloudera.org:8080/#/c/16876/1/src/kudu/server/rpc_server.cc@222 PS1, Line 222: messenger_->set_running(); > What about RPC messenger at the client side? Should we toggle its state as Good point. I actually don't think there's a good reason for this, other than it seeming natural, given the state is about "running". Instead, I'll rename the states to be more service-specific, and mention that not all Messengers will register/unregister services. -- To view, visit http://gerrit.cloudera.org:8080/16876 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04e2379de4cf632d257b93cd701d7c73cb2bbaed Gerrit-Change-Number: 16876 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Dec 2020 02:41:27 +0000 Gerrit-HasComments: Yes
