Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16886 )
Change subject: KUDU-2612: two more scenarios for txn keepalive in client ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16886/2/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/16886/2/src/kudu/client/client-test.cc@7661 PS2, Line 7661: > Ah right. For some reason I assumed defaults. Indeed, that's not obvious if just looking at this diff. Not sure what's the best way to make it more obvious: creating a sub-class ClientTxnTest of ClientTest for txn-related scenarios and make the override only in ClientTxnTest::SetUp() or add a comment into each txn scenario about the override in ClientTest::SetUp()? I think I'll leave this as is for a while. Meanwhile, let me know what do you think will help to make this better from the readability perspective -- I'll address it in a separate changelist. Thank you! -- To view, visit http://gerrit.cloudera.org:8080/16886 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42988996f1ddb1cd456d289ea7e15586bd7e3dc7 Gerrit-Change-Number: 16886 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 18 Dec 2020 06:51:51 +0000 Gerrit-HasComments: Yes
