Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16887 )
Change subject: [java] allow disabling TLS transportation from java client ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16887/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java File java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java: http://gerrit.cloudera.org:8080/#/c/16887/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@102 PS3, Line 102: DISABLE_KUDU_CLIENT_TLS nit: rename into KUDU_CLIENT_DISABLE_TLS That would follow the suite with naming of other Kudu-specific environment variables. http://gerrit.cloudera.org:8080/#/c/16887/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java@260 PS3, Line 260: builder.addSupportedFeatures(RpcFeatureFlag.TLS_AUTHENTICATION_ONLY); > Perhaps instead of disabling TLS all together we could use TLS_AUTHENTICATI This sounds like a good idea, but TLS_AUTHENTICATION_ONLY should be present on the both side to work as expected. That means that simply adding TLS_AUTHENTICATION_ONLY on the client wouldn't do any effect unless the server also adds that into the list of its features when negotiating a connection with a client that has TLS_AUTHENTICATION_ONLY in the features. That means it would require a separate changelist to make sense of using TLS_AUTHENTICATION_ONLY effectively here. -- To view, visit http://gerrit.cloudera.org:8080/16887 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I762b9d6ef9257a7853684dd0aef315e5c5bba8ed Gerrit-Change-Number: 16887 Gerrit-PatchSet: 3 Gerrit-Owner: wangning <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 22 Dec 2020 21:25:16 +0000 Gerrit-HasComments: Yes
