Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16859 )
Change subject: [master] KUDU-2671: Range specific hashing at table creation time. ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16859/2/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/16859/2/src/kudu/common/partition.cc@418 PS2, Line 418: if (!range_hash_schemas.empty()) { : if (!split_rows.empty()) { : return Status::InvalidArgument("Both 'split_rows' and 'range_hash_schemas' cannot be " : "populated at the same time."); : } : if (range_bounds.size() != range_hash_schemas.size()) { : > Ack After much thought, I've decided that the best route is what you said above about only these cases being possible: - The user is using the old API. 'split_rows' and 'range_bounds' are allowed, but not 'range_hash_schemas' - The user is using the new API. 'split_rows' is not allowed at all, but 'range_hash_schemas' is allowed. If 'range_hash_schemas' is an empty vector, this is equivalent to a vector of empty schemas. An empty schema is shorthand for using the table-wide default. If the user wants to specify 'split_rows' with 'range_bounds', we should exclude the new API from that. On the other hand, if the user wants to specify some 'range_bounds' using the new API but for other 'range_bounds' they don't want to specify a hash schema, they should still use the new API but just input an empty vector. -- To view, visit http://gerrit.cloudera.org:8080/16859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f0dcbc3324f8f2d6e99b4d169fdf5c7f7dff95d Gerrit-Change-Number: 16859 Gerrit-PatchSet: 10 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 22 Dec 2020 21:26:08 +0000 Gerrit-HasComments: Yes
