Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16885 )
Change subject: [docker] Add support for openSUSE in the Docker build ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh File docker/bootstrap-dev-env.sh: http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185 PS2, Line 185: update > update does a refresh and update and matches the behavior of the other OS v ack http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@185 PS2, Line 185: zypper > I don't think we have a license issue given it builds with no problems. The OK, but then I'm curious: why do we use DEBIAN_FRONTEND for Ubuntu/Debian which is similar to --non-interactive for zypper? http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-dev-env.sh@209 PS2, Line 209: openssl-devel > This was taken from the install instructions: https://kudu.apache.org/docs/ I see: I was under impression openssl was enough on SLES. Most likely I was wrong, but regardless we should keep this list and the list in the build instructions in sync, I agree. http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh File docker/bootstrap-java-env.sh: http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-java-env.sh@82 PS2, Line 82: clean > for what? To remove repo metadata as well, I guess. As per https://en.opensuse.org/SDB:Zypper_manual_%28plain%29 clean (cc) [options] [alias|name|#|URI]... Clean the local caches for all known or specified repositories. By default, only caches of downloaded packages are cleaned. -m, --metadata Clean repository metadata cache instead of package cache. -M, --raw-metadata Clean repository raw metadata cache instead of package cache. -a, --all Clean both repository metadata and package caches. http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh File docker/bootstrap-runtime-env.sh: http://gerrit.cloudera.org:8080/#/c/16885/2/docker/bootstrap-runtime-env.sh@95 PS2, Line 95: openssl > It doesn't appear to be required for runtime. Ah, I see -- it seems I confused run-time and development images. Does krb5-devel is needed for runtime? -- To view, visit http://gerrit.cloudera.org:8080/16885 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c1ce282fda67db5043445a139c888bc74c44680 Gerrit-Change-Number: 16885 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 23 Dec 2020 20:22:21 +0000 Gerrit-HasComments: Yes
