Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16907 )
Change subject: KUDU-3225 Fixes error 'vld1q_u8_x4' was not declared ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16907/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16907/1//COMMIT_MSG@10 PS1, Line 10: always I might be missing something, but it seems the updated code introduces vld1q_u8_x4 only for non-clang case, no? http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h File src/kudu/util/sse2neon.h: http://gerrit.cloudera.org:8080/#/c/16907/1/src/kudu/util/sse2neon.h@183 PS1, Line 183: __aarch64__ I'm curious: would this compile with GCC 10 on ARM? It seems this should be defined only for GCC 9 and older. At least, that's so at https://github.com/DLTcollab/sse2neon/blob/471743745dd09798fb7df87a9b7f31f543aa31da/sse2neon.h#L303-L316 -- To view, visit http://gerrit.cloudera.org:8080/16907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2538e6ca321e89edb46d54f620b305b8e005f173 Gerrit-Change-Number: 16907 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 04 Jan 2021 17:28:44 +0000 Gerrit-HasComments: Yes
