Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/16874 )

Change subject: [Java] Upgrade dependencies
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16874/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java:

http://gerrit.cloudera.org:8080/#/c/16874/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiator.java@427
PS2, Line 427:     while (((ByteBuf) 
embedder.outboundMessages().peek()).readableBytes() == 0) {
             :       embedder.readOutbound();
             :     }
Just curious: is this change due to the fact that with the newer version of 
some related packages now there are multiple empty messages, while with prior 
versions there could be at most one empty message?



--
To view, visit http://gerrit.cloudera.org:8080/16874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4b319a67f629bcb60ae54187cee1c3257d6e1a2
Gerrit-Change-Number: 16874
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 04 Jan 2021 22:44:33 +0000
Gerrit-HasComments: Yes

Reply via email to