Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16899 )
Change subject: [consensus] Allow sending status-only request messages to FAILED peer ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16899/1/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/16899/1/src/kudu/consensus/consensus_queue.h@561 PS1, Line 561: : // The id of the tablet. > Hmm. I don't find one more readable than the other. I'll keep it as is. Sure, the case for the &&ed version being more readable is that you could easily summarize it as: !(allow_status_messages_on_failure && is_failed) in which case we should send a status message, not a log message. That IMO is more straightforward than reasoning about the ||s. Though I don't feel strongly about it. -- To view, visit http://gerrit.cloudera.org:8080/16899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I229cc739c1b5ec7b11ce05d5e6b1b8e9d654d6f7 Gerrit-Change-Number: 16899 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 01:17:22 +0000 Gerrit-HasComments: Yes
