Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 )
Change subject: KUDU-2612 Java client transaction API ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/16894/2/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@1181 PS2, Line 1181: This call is blocking > Would you mind explain a bit more about why it is blocking? You mean we should follow the suite of majority of methods in this interface and return something like Deferred<KuduTransaction> and add 'KuduTransaction newTransaction()' into the KuduClient's interface? I didn't see much value in returning Deferred<KuduTransaction> because I don't quite see the use cases for that. Let me know if you think otherwise and we should have this returning Deferred<KuduTransaction>, keeping the deferred purity of this interface. -- To view, visit http://gerrit.cloudera.org:8080/16894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbb18e1ac0454a8ef9e3486430dfaa336e381e07 Gerrit-Change-Number: 16894 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Wed, 06 Jan 2021 09:03:42 +0000 Gerrit-HasComments: Yes
