Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16927 )
Change subject: [build] Automate using GCC-8 on SLES 12 ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh File build-support/enable_devtoolset.sh: http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@46 PS2, Line 46: "$CC" -a ! "$CXX" > Just to make sure: we don't want to handle the case case if CC is set but C I thought about this but chose to match the existing behavior and expect that case to be rare. We can improve this script in follow up changes to be more flexible. http://gerrit.cloudera.org:8080/#/c/16927/2/build-support/enable_devtoolset.sh@53 PS2, Line 53: /usr/bin/gcc-8 > nit: may it be a case when /usr/bin/gcc-8 isn't available? Should we bail I was on the fence about it. We can definitely do that in a follow up and the failure should be obvious if it is missing as is too. -- To view, visit http://gerrit.cloudera.org:8080/16927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50237cc900c9450bf1b5fbc7866353c17e3ef10b Gerrit-Change-Number: 16927 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Jan 2021 18:07:18 +0000 Gerrit-HasComments: Yes
