Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16941 )
Change subject: KUDU-3205: Fix building scan tokens when tablet not found errors occur ...................................................................... Patch Set 1: Code-Review+1 (1 comment) LGTM, lint error aside. http://gerrit.cloudera.org:8080/#/c/16941/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java: http://gerrit.cloudera.org:8080/#/c/16941/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@263 PS1, Line 263: * Get replicas of this tablet. The returned list may not be mutated. nit: do you think it's worth adding a note here expressing that the replicas may point at tablet servers not included in getTabletServersCopy(). It's added at the callsites, but it might be worth calling out closer to the method definitions too. -- To view, visit http://gerrit.cloudera.org:8080/16941 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I68679dee1ad7ebca405dd6e086770f3e034e310c Gerrit-Change-Number: 16941 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 11 Jan 2021 23:56:47 +0000 Gerrit-HasComments: Yes
