Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16938 )
Change subject: [util] add a few new metrics in MaintenanceManager ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16938/2/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: PS2: > Would be great to get some basic test coverage for our new metrics here. It's in PS2 of https://gerrit.cloudera.org/#/c/16937/ http://gerrit.cloudera.org:8080/#/c/16938/2/src/kudu/util/maintenance_manager_metrics.cc File src/kudu/util/maintenance_manager_metrics.cc: http://gerrit.cloudera.org:8080/#/c/16938/2/src/kudu/util/maintenance_manager_metrics.cc@26 PS2, Line 26: "Number of times when calling Prepare() on a maintenance " : "operation failed", > nit: it might be worth mentioning why Prepare() might fail, e.g. if an op c I added it as a comment in the code right here: not sure we want such specifics in the description of the metric itself. -- To view, visit http://gerrit.cloudera.org:8080/16938 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5420afd605f9bd22207af142b49e73336907486 Gerrit-Change-Number: 16938 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 12 Jan 2021 08:47:41 +0000 Gerrit-HasComments: Yes
