Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16943 )
Change subject: [build] Add more options to the compatibility checker script ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16943/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16943/2//COMMIT_MSG@10 PS2, Line 10: chekcer checker http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py File build-support/check_compatibility.py: http://gerrit.cloudera.org:8080/#/c/16943/2/build-support/check_compatibility.py@216 PS2, Line 216: parser.add_argument("--force-download-deps", action='store_true', : help="Download dependencies (i.e. japicmp) even if they are already present") I could not find the code that uses this newly introduced option in run_japicmp(): not sure I understand how this can work. Maybe, there is some Python magic around this? -- To view, visit http://gerrit.cloudera.org:8080/16943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fa93bd069b4412266d3cafb00e1d49f578f0516 Gerrit-Change-Number: 16943 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Jan 2021 18:49:19 +0000 Gerrit-HasComments: Yes
