Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16948 )
Change subject: [client] updated multi-row transaction API ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16948/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16948/1/src/kudu/client/client.h@557 PS1, Line 557: Serialize(s > We could have two methods like that, but I think it looks ugly and even con I guess we can make an exception w.r.t. code style conventions because the code style convention here contradicts the simple usability criteria. OK, I'll post new PS for this patch. -- To view, visit http://gerrit.cloudera.org:8080/16948 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id646c41d60f385f079ebfaec2daf7c2a108306b2 Gerrit-Change-Number: 16948 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Jan 2021 19:04:50 +0000 Gerrit-HasComments: Yes
