Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16894 )
Change subject: KUDU-2612 Java client transaction API ...................................................................... Patch Set 7: > We discussed offline changing from a KuduTransactionSerializer to > the serializer method which takes an option class. The benefit is > all the serialize/deserialize methods are on the KuduTransaction > itself and doesn't require a short lived object created for each > serialize/deserialize call. Yes, indeed. I posted PS7 using the suggested approach. -- To view, visit http://gerrit.cloudera.org:8080/16894 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idbb18e1ac0454a8ef9e3486430dfaa336e381e07 Gerrit-Change-Number: 16894 Gerrit-PatchSet: 7 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Thu, 14 Jan 2021 23:53:36 +0000 Gerrit-HasComments: No
