[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/16955 )
Change subject: allow customize sasl_proto_name instead of always using "kudu" ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/16955/1/src/kudu/rpc/messenger.cc File src/kudu/rpc/messenger.cc: http://gerrit.cloudera.org:8080/#/c/16955/1/src/kudu/rpc/messenger.cc@58 PS1, Line 58: sasl_proto_name > I'm not sure this is the best name for the flag if thinking about end-users According to the following docs: https://www.cyrusimap.org/sasl/sasl/reference/manpages/library/sasl_server_new.html https://opensource.apple.com/source/passwordserver_sasl/passwordserver_sasl-11/cyrus_sasl/doc/programming.html#sasl_server_new This name is used to registered as a service, it suggests using protocol name, and is used by Kerberos, So, what is about "sasl_service_name", "sasl_krb5_principal_name"? http://gerrit.cloudera.org:8080/#/c/16955/1/src/kudu/rpc/messenger.cc@59 PS1, Line 59: Default is kudu. > This is not needed: a help string for a gflag shows the default value autom Let me remove it http://gerrit.cloudera.org:8080/#/c/16955/1/src/kudu/rpc/messenger.cc@60 PS1, Line 60: sasl_proto_name > Can any string be supplied here and work just fine (an empty one, with spac Good suggestion. I'll add this. http://gerrit.cloudera.org:8080/#/c/16955/1/src/kudu/rpc/messenger.cc@81 PS1, Line 81: FLAGS_sasl_proto_name > Why not to use the same approach as for the rpc_authentication_ field, wher If I set_sasl_proto_name() in server_base.cc, only kudu-master and kudu-tserver can use it. But when I run the kudu command line, for example, "kudu master list xxx", the code https://github.com/apache/kudu/blob/master/src/kudu/client/client.cc#L355 calls MessageBuilder without setting sasl_proto_name, as a result, "kudu" is still used. So, it is better using a central place to set the proto name in MessengerBuilder. -- To view, visit http://gerrit.cloudera.org:8080/16955 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79ccd0441f1d5eb087e2545e1ca8055078da5566 Gerrit-Change-Number: 16955 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 Jan 2021 06:22:13 +0000 Gerrit-HasComments: Yes
