Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16958 )
Change subject: scripts: add extra flags to start_kudu.sh ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16958/1/src/kudu/scripts/start_kudu.sh File src/kudu/scripts/start_kudu.sh: http://gerrit.cloudera.org:8080/#/c/16958/1/src/kudu/scripts/start_kudu.sh@92 PS1, Line 92: EXTRA_TSERVER_FLAGS Given the way how this used below, I'm curious how this is supposed to work if supplying more than one flag for the --tserver-flags or the --master-flags option? Is that something about specifying multiple -T and -M options, like -T -flag0=x -T -flag1=y ... ? If so, then I'd expect $2 to be appended to the EXTRA_TSERVER_FLAGS. If not, then I guess it's possible to specify only a single flag for -T/-M effectively? -- To view, visit http://gerrit.cloudera.org:8080/16958 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8808570259b084970c228fcac5cb4ea7e0b8d1e Gerrit-Change-Number: 16958 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 16 Jan 2021 06:16:51 +0000 Gerrit-HasComments: Yes
