Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 )
Change subject: wip KUDU-2612: background task to commit transaction ...................................................................... Patch Set 1: (3 comments) Just a quick walk through, haven't looked into the detail yet. http://gerrit.cloudera.org:8080/#/c/16952/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16952/1//COMMIT_MSG@24 PS1, Line 24: There are some nuances here > I haven't looked deep into the code yet, just a few top-level questions at Another error handling question is maybe a little bit early to think about since we only want to support REPEATED READ isolation level first: what happens if one of the two (or more) transactions have concurrent write to the same range of data based on the read which can cause write skew. We may want to abort one of the affected transaction and roll back? Or should we just send error back to client indicate something going wrong with the transaction and to retry. http://gerrit.cloudera.org:8080/#/c/16952/1/src/kudu/transactions/txn_status_entry.cc File src/kudu/transactions/txn_status_entry.cc: http://gerrit.cloudera.org:8080/#/c/16952/1/src/kudu/transactions/txn_status_entry.cc@a45 PS1, Line 45: This condition no longer hold? http://gerrit.cloudera.org:8080/#/c/16952/1/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/16952/1/src/kudu/tserver/ts_tablet_manager.cc@1258 PS1, Line 1258: txn_status_manager_pool_->Shutdown(); shut down the txn_commit_pool_ when tserver is shutting down? -- To view, visit http://gerrit.cloudera.org:8080/16952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2258dded3ab3d527cb5d0abdc7d5e7deb4da15e Gerrit-Change-Number: 16952 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Jan 2021 01:59:07 +0000 Gerrit-HasComments: Yes
