Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16956 )
Change subject: KUDU-3230: Fix the issue of hardcode sasl_proto_name ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/16956/2//COMMIT_MSG Commit Message: PS2: It would be great to add a test to verify that a client is able to negotiate a secure connection with the server using a custom Kerberos credentials. http://gerrit.cloudera.org:8080/#/c/16956/2/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/16956/2/src/kudu/integration-tests/security-itest.cc@228 PS2, Line 228: TEST_F(SecurityITest, TestSaslProtoName) { : // set a non-default name : FLAGS_sasl_krb5_principal_name = "imap"; : std::shared_ptr<Messenger> messenger; : CHECK_OK(rpc::MessengerBuilder("test-messenger") : .set_num_reactors(1) : .set_max_negotiation_threads(1) : .Build(&messenger)); : ASSERT_EQ(messenger->sasl_proto_name(), : FLAGS_sasl_krb5_principal_name); What does this test tries to verify? -- To view, visit http://gerrit.cloudera.org:8080/16956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia1c8f9d9f772d000d9a588e4e9d6028711a62915 Gerrit-Change-Number: 16956 Gerrit-PatchSet: 2 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 Jan 2021 18:06:55 +0000 Gerrit-HasComments: Yes
