Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16967 )
Change subject: KUDU-2612 keep-alive txn heartbeating for Java client ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/16967/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeepTransactionAliveRequest.java File java/kudu-client/src/main/java/org/apache/kudu/client/KeepTransactionAliveRequest.java: http://gerrit.cloudera.org:8080/#/c/16967/3/java/kudu-client/src/main/java/org/apache/kudu/client/KeepTransactionAliveRequest.java@46 PS3, Line 46: txnId > nit: check txnId > INVALID_TXN_ID? Done http://gerrit.cloudera.org:8080/#/c/16967/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java: http://gerrit.cloudera.org:8080/#/c/16967/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduTransaction.java@628 PS3, Line 628: TODO(aserbin): should we send next heartbeat sooner? E.g., retry : // immediately, and do such retry only once after a : // failure like this. The idea is to avoid missing : // heartbeats in situations where the second attempt : // after keepaliveMillis/2 would as well due to a network : // issue, but immediate retry could succeed. > Do we have a test case for this? Nope, no test case for this one yet. I guess that's conditional upon implementing this TODO: https://gerrit.cloudera.org/#/c/16929/9/java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java@440 Once the TODO is addressed, I can add a test case for this (and that's what I'm going to do). Thank you for pointing at this! -- To view, visit http://gerrit.cloudera.org:8080/16967 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6326a5452223d8173b2da004bb5f3ab0c1e6ae4e Gerrit-Change-Number: 16967 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 27 Jan 2021 02:45:33 +0000 Gerrit-HasComments: Yes
