Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16998 )
Change subject: [blog] Add post announcing Kudu 1.14.0 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/16998/2/_posts/2021%E2%80%9301-28-apache-kudu-1-14-0-release.md File _posts/2021–01-28-apache-kudu-1-14-0-release.md: http://gerrit.cloudera.org:8080/#/c/16998/2/_posts/2021%E2%80%9301-28-apache-kudu-1-14-0-release.md@36 PS2, Line 36: C++ client by setting the KUDU_REQUIRE_FIPS_MODE > For some reason this jumped on me when going through the these announcement One more point here. I'm not sure having KUDU_REQUIRE_FIPS_MODE env variable is the best way of enforcing the FIPS mode in the long run. I think it's fine to keep the environment variable as well for a while, but I guess in the future we might add a new flag for Kudu servers to enforce that. The reason is that environment-based controls are rather brittle, and we avoided using them at all from the very beginning. KUDU_REQUIRE_FIPS_MODE is the first one used outside of test-related functionality in Kudu. I was on fence whether that sort of enforcement is really needed for the client side, frankly. I'm still not sure about that. Just two cents from my side here. -- To view, visit http://gerrit.cloudera.org:8080/16998 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: Idc1f6bc0c98151ffb250436d6c26701f8a0319e4 Gerrit-Change-Number: 16998 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Comment-Date: Thu, 28 Jan 2021 18:22:49 +0000 Gerrit-HasComments: Yes