Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17021 )
Change subject: [test] enable TxnStatusManagerITest.TxnKeepAliveMultiTxnStatusManagerInstances ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17021/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17021/1//COMMIT_MSG@10 PS1, Line 10: And deflake it by decreasing the intervals : of KeepTransactionAlive calls and reduce the RPC timeout I saw some other changes made. Are those extra changes necessary to make the test stable? If yes, please explain the essence of those extra changes. If not, revert them for the sake of clarity? http://gerrit.cloudera.org:8080/#/c/17021/1/src/kudu/integration-tests/txn_status_manager-itest.cc File src/kudu/integration-tests/txn_status_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/17021/1/src/kudu/integration-tests/txn_status_manager-itest.cc@391 PS1, Line 391: LOG(INFO) << "Starting to restart the tserver.."; It seems this line was used in debugging and is no longer needed -- please remove it. -- To view, visit http://gerrit.cloudera.org:8080/17021 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I27afb53ecb9d28dc15fa7f0c26e677dafee2030f Gerrit-Change-Number: 17021 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 04 Feb 2021 03:44:27 +0000 Gerrit-HasComments: Yes
