Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/16952 )
Change subject: KUDU-2612: background task to commit transaction ...................................................................... Patch Set 16: Code-Review+2 (3 comments) Looks good to me. I didn't get a chance to check the tests closely. But I believe Alexey has done so. Thanks a lot Andrew for the patch! http://gerrit.cloudera.org:8080/#/c/16952/14/src/kudu/transactions/txn_status_manager.cc File src/kudu/transactions/txn_status_manager.cc: http://gerrit.cloudera.org:8080/#/c/16952/14/src/kudu/transactions/txn_status_manager.cc@257 PS14, Line 257: participant_ids_[participant_idx], : std::move(op_pb), : MonoDelta::FromMilliseconds(FLAGS_txn_background_rpc_timeout_ms), : std::move(participated_cb), : &begin_commit_timestamps_[participant_idx]); : } > It's not identical everywhere, but sure. Ack http://gerrit.cloudera.org:8080/#/c/16952/14/src/kudu/transactions/txn_status_manager.cc@268 PS14, Line 268: pated_cb = [this, scoped_this = std::move(scoped_this), : participant_idx, commit_timestamp] (const Status& s) { : if (IsShuttingDownCleanupIfLastOp()) { : > Yeah, added a comment to make that clear that it's intentional. Ack http://gerrit.cloudera.org:8080/#/c/16952/14/src/kudu/transactions/txn_status_manager.cc@787 PS14, Line 787: : std::lock_guar > There is always at least the BEGIN_COMMIT op timestamp, regardless of any w Ack -- To view, visit http://gerrit.cloudera.org:8080/16952 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2258dded3ab3d527cb5d0abdc7d5e7deb4da15e Gerrit-Change-Number: 16952 Gerrit-PatchSet: 16 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 05 Feb 2021 08:12:29 +0000 Gerrit-HasComments: Yes
