Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17024 )

Change subject: [master] turn off client location assignment by default
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/17024/2//COMMIT_MSG@20
PS2, Line 20: This is a first step towards addressing KUDU-3212.
> Is the plan to improve client location assignment to the point that it can
Yep, that might be an option.  However, I'm not exactly sure of the priorities 
for the nearest future.  I guess we can discuss it offline.


http://gerrit.cloudera.org:8080/#/c/17024/2/src/kudu/master/master_service.cc
File src/kudu/master/master_service.cc:

http://gerrit.cloudera.org:8080/#/c/17024/2/src/kudu/master/master_service.cc@88
PS2, Line 88: By default they do if the location assignment command is set
> nit: needs an update? Probably worth making the description agnostic to whe
Nice catch!

Done.



--
To view, visit http://gerrit.cloudera.org:8080/17024
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78474ced0a0129b3f2b1add55f6f908a136106d0
Gerrit-Change-Number: 17024
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 05 Feb 2021 23:36:58 +0000
Gerrit-HasComments: Yes

Reply via email to