Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17034 )
Change subject: [gutil] EmplaceOrDie() to return reference ...................................................................... [gutil] EmplaceOrDie() to return reference I found it's useful for EmplaceOrDie() to return a reference to the object that is constructed in-place in the container. To implement this change, I needed to use std::enable_if() dance because EmplaceOrDie() is already used in Kudu codebase for not only dictionary, but for set containers as well: that's so in src/kudu/ranger/ranger_client.cc at least. Change-Id: Ife1e07b7454078d3392555866fd32b89fac28af7 Reviewed-on: http://gerrit.cloudera.org:8080/17034 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Andrew Wong <[email protected]> --- M src/kudu/gutil/map-util.h M src/kudu/util/map-util-test.cc 2 files changed, 53 insertions(+), 6 deletions(-) Approvals: Alexey Serbin: Verified Andrew Wong: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17034 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ife1e07b7454078d3392555866fd32b89fac28af7 Gerrit-Change-Number: 17034 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
