Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17036 )
Change subject: [util] remove AutoReleasePool and cleanup related code ...................................................................... [util] remove AutoReleasePool and cleanup related code This patch removes AutoReleasePool class and changes just two places where it was used to store heap-allocated objects. With this patch, objects of appropriate type are wrapped into std::unique_ptr and stored in std::deque container. Along the way, I did other minor code cleanup. The motivation for this change is reducing number of memory allocations and removing unneeded complexity in the code. Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c Reviewed-on: http://gerrit.cloudera.org:8080/17036 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Hao Hao <[email protected]> --- M src/kudu/client/client.cc M src/kudu/client/scan_configuration.cc M src/kudu/client/scan_configuration.h M src/kudu/tablet/ops/alter_schema_op.cc M src/kudu/tablet/ops/alter_schema_op.h M src/kudu/tablet/ops/op.cc M src/kudu/tablet/ops/op.h D src/kudu/util/auto_release_pool.h 8 files changed, 49 insertions(+), 146 deletions(-) Approvals: Alexey Serbin: Verified Hao Hao: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17036 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I8adb5d08ec37e716baf524cb6c5f52366553883c Gerrit-Change-Number: 17036 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
