Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17017 )
Change subject: KUDU-2612: add background task to abort transaction participants ...................................................................... Patch Set 8: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/17017/5/src/kudu/integration-tests/txn_commit-itest.cc File src/kudu/integration-tests/txn_commit-itest.cc: http://gerrit.cloudera.org:8080/#/c/17017/5/src/kudu/integration-tests/txn_commit-itest.cc@332 PS5, Line 332: UALLY([&] { > At first my rationale was that if the transaction was aborted, from a clien Ack, sounds good to me as well. http://gerrit.cloudera.org:8080/#/c/17017/5/src/kudu/transactions/txn_status_manager.cc File src/kudu/transactions/txn_status_manager.cc: http://gerrit.cloudera.org:8080/#/c/17017/5/src/kudu/transactions/txn_status_manager.cc@982 PS5, Line 982: RETURN_NOT_OK(status_tablet_.UpdateTransaction( : txn_id, mutable_data->pb, ts_error)); : txn_lock.Commit(); : return Status::OK(); : } : : Status TxnStatusManager::FinalizeAbortTransaction(int64_t txn_id) { : leader_lock_.AssertAcquiredForReading(); : > Ah nice catch! This isn't necessary -- the commit tasks clean up after them Ack -- To view, visit http://gerrit.cloudera.org:8080/17017 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I484c315c6f7331c5ec12cb06370fbaae9c7c343e Gerrit-Change-Number: 17017 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 10 Feb 2021 00:37:52 +0000 Gerrit-HasComments: Yes
