Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17044 )
Change subject: [transactions] add TxnSystemClient::CheckOpenTxnSystemTable() ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17044/4/src/kudu/integration-tests/txn_status_table-itest.cc File src/kudu/integration-tests/txn_status_table-itest.cc: http://gerrit.cloudera.org:8080/#/c/17044/4/src/kudu/integration-tests/txn_status_table-itest.cc@682 PS4, Line 682: s nit: extra space http://gerrit.cloudera.org:8080/#/c/17044/4/src/kudu/integration-tests/txn_status_table-itest.cc@696 PS4, Line 696: newTxnId nit: snake_case? http://gerrit.cloudera.org:8080/#/c/17044/4/src/kudu/integration-tests/txn_status_table-itest.cc@697 PS4, Line 697: { : // Behind the scenes, create tablets for the next transaction IDs range : // and start a new transaction. : { : shared_ptr<KuduClient> c; : KuduClientBuilder builder; : ASSERT_OK(cluster_->CreateClient(&builder, &c)); : txn_sys_client_->client_ = std::move(c); : } : // Re-open the system table. : ASSERT_OK(txn_sys_client_->OpenTxnStatusTable()); : ASSERT_OK(txn_sys_client_->AddTxnStatusTableRange( : kPartitionWidth, 2 * kPartitionWidth)); : ASSERT_OK(txn_sys_client_->BeginTransaction(newTxnId, kUser)); : } : nit: I'm curious, rather than doing this dance in swapping the client in, why not just instantiate a new TxnSystemClient to add the partition? Seems that'd be more organic in exercising this codepath since that is what happens (the TxnManager instantiates has its own client) -- To view, visit http://gerrit.cloudera.org:8080/17044 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If2e9b3cfc1566ff8ddbe56be980fb7d360759c0f Gerrit-Change-Number: 17044 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Comment-Date: Wed, 10 Feb 2021 01:23:22 +0000 Gerrit-HasComments: Yes
