Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17025
to look at the new patch set (#3).
Change subject: wip KUDU-2671: Adds new fields to PartitionSchema.
......................................................................
wip KUDU-2671: Adds new fields to PartitionSchema.
This patch introduces two new fields to PartitionSchema, range bounds
and their respective hash bucket schemas. Any instance that assumes
the same hash schemas are used for each range will need these new fields.
Some of the more important instances include partition pruning and many
of the internal PartitionSchema functions.
This patch is WIP because I'm mostly looking for feedback on the approach
of adding the two new fields and its encoder/decoder functions. The new
client_schema parameter in PartitionSchema::FromPB() is necessary for
the RowOperationsPB decoder. For the call sites that don't provide an
explicit client schema, they use schema.CopyWithoutColumnIds(). I haven't
written any tests but would like some feedback about the viability of
using the schema without its columnIds as the client_schema.
I moved RowOperationsPB to a separate .proto file due to some circular
dependency issues between common.proto and wire_protocol.proto. Most of
the proto changes in this patch revolve around this change.
Change-Id: Ic5d8615ab9967fdb40292b9c77eb68a19baeca1d
---
M java/kudu-client/src/main/java/org/apache/kudu/client/Operation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestOperation.java
M src/kudu/client/client-internal.cc
M src/kudu/client/scan_token-internal.cc
M src/kudu/common/CMakeLists.txt
M src/kudu/common/common.proto
M src/kudu/common/partition-test.cc
M src/kudu/common/partition.cc
M src/kudu/common/partition.h
M src/kudu/common/partition_pruner-test.cc
M src/kudu/common/partition_pruner.cc
M src/kudu/common/row_operations-test.cc
M src/kudu/common/row_operations.h
A src/kudu/common/row_operations.proto
M src/kudu/common/scan_spec-test.cc
M src/kudu/common/wire_protocol.proto
M src/kudu/integration-tests/alter_table-test.cc
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/master/catalog_manager.cc
M src/kudu/master/master.proto
M src/kudu/master/master_path_handlers.cc
M src/kudu/master/sys_catalog.cc
M src/kudu/tablet/tablet-harness.h
M src/kudu/tablet/tablet_metadata.cc
M src/kudu/tools/tool_action_remote_replica.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver.proto
29 files changed, 466 insertions(+), 123 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/17025/3
--
To view, visit http://gerrit.cloudera.org:8080/17025
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic5d8615ab9967fdb40292b9c77eb68a19baeca1d
Gerrit-Change-Number: 17025
Gerrit-PatchSet: 3
Gerrit-Owner: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
