Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17063 )
Change subject: [test] Start using GTEST_SKIP where applicable ...................................................................... [test] Start using GTEST_SKIP where applicable Use the GTEST_SKIP() macro in SKIP_IF_SLOW_NOT_ALLOWED() instead of early return so that test is marked as SKIPPED instead of PASSED. Replace instances where macro SKIP_IF_SLOW_NOT_ALLOWED() is not used. Use the GTEST_SKIP macro for a crypto test that is skipped in FIPS mode. On the dist-test UI, verified a skipped test is marked as "successful" so no negative impact and same as earlier but the test doesn't get marked as "skipped" or such. Marking a test as skipped will require separate change to the dist-test UI. Sample output when tests are skipped: [----------] Global test environment tear-down [==========] 18 tests from 4 test suites ran. (27888 ms total) [ PASSED ] 14 tests. [ SKIPPED ] 4 tests, listed below: [ SKIPPED ] ParameterizedAddMasterTest.TestAddMasterCatchupFromWAL/0 [ SKIPPED ] ParameterizedAddMasterTest.TestAddMasterCatchupFromWAL/1 [ SKIPPED ] ParameterizedAddMasterTest.TestAddMasterSysCatalogCopy/0 [ SKIPPED ] ParameterizedAddMasterTest.TestAddMasterSysCatalogCopy/1 Change-Id: I4466bdde3965921d527131e76ad221643ff05705 Reviewed-on: http://gerrit.cloudera.org:8080/17063 Tested-by: Kudu Jenkins Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/client/client-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/integration-tests/alter_table-test.cc M src/kudu/integration-tests/auth_token_expire-itest.cc M src/kudu/integration-tests/client-negotiation-failover-itest.cc M src/kudu/integration-tests/consensus_peer_health_status-itest.cc M src/kudu/integration-tests/create-table-itest.cc M src/kudu/integration-tests/create-table-stress-test.cc M src/kudu/integration-tests/delete_table-itest.cc M src/kudu/integration-tests/location_assignment-itest.cc M src/kudu/integration-tests/master_cert_authority-itest.cc M src/kudu/integration-tests/master_failover-itest.cc M src/kudu/integration-tests/open-readonly-fs-itest.cc M src/kudu/integration-tests/raft_config_change-itest.cc M src/kudu/integration-tests/raft_consensus-itest.cc M src/kudu/integration-tests/raft_consensus_failure_detector-imc-itest.cc M src/kudu/integration-tests/raft_consensus_nonvoter-itest.cc M src/kudu/integration-tests/raft_consensus_stress-itest.cc M src/kudu/integration-tests/security-faults-itest.cc M src/kudu/integration-tests/security-unknown-tsk-itest.cc M src/kudu/integration-tests/tablet_copy-itest.cc M src/kudu/integration-tests/tablet_copy_client_session-itest.cc M src/kudu/integration-tests/tablet_replacement-itest.cc M src/kudu/integration-tests/token_signer-itest.cc M src/kudu/integration-tests/tombstoned_voting-imc-itest.cc M src/kudu/integration-tests/tombstoned_voting-stress-test.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/security/crypto-test.cc M src/kudu/security/token-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/compaction_policy-test.cc M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/kudu-admin-test.cc M src/kudu/tools/rebalancer_tool-test.cc M src/kudu/util/monotime-test.cc M src/kudu/util/test_util.h M src/kudu/util/thread-test.cc 37 files changed, 86 insertions(+), 304 deletions(-) Approvals: Kudu Jenkins: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17063 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4466bdde3965921d527131e76ad221643ff05705 Gerrit-Change-Number: 17063 Gerrit-PatchSet: 4 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241)
