Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17090 )
Change subject: KUDU-2671: Adds compatibility for per range hash schemas with unbounded ranges. ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17090/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17090/3/src/kudu/common/partition.cc@523 PS3, Line 523: Finds nit: here and elsewhere, when describing code with in-line comments, we typically use imperative tense rather than present tense, and reserve present tense for comments that describe functions and members in the declarations/headers. http://gerrit.cloudera.org:8080/#/c/17090/3/src/kudu/common/partition.cc@537 PS3, Line 537: : // nit: similar to other comments, separate with an empty comment line rather than an entirely empty line. -- To view, visit http://gerrit.cloudera.org:8080/17090 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5f6c709e211359b04f7597af5f670c787bda7481 Gerrit-Change-Number: 17090 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 23 Feb 2021 07:24:09 +0000 Gerrit-HasComments: Yes
