Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17127 )
Change subject: KUDU-2612: don't return NOT_FOUND when BEGIN_TXN has not yet run ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc File src/kudu/tablet/txn_participant-test.cc: http://gerrit.cloudera.org:8080/#/c/17127/1/src/kudu/tablet/txn_participant-test.cc@266 PS1, Line 266: ABORT_TXN As a second thought, I realized I don't clearly see how we can cleanly abort a transaction which faltered at one of its participants and doesn't have metadata about started transaction if ABORT_TXN returns ILLEGAL_STATE as well. Is it going to be addressed in a separate patch or https://gerrit.cloudera.org/#/c/17022/ will take care of this as well? -- To view, visit http://gerrit.cloudera.org:8080/17127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8fa8caba384ee30536114a3e6466ad90b6d8e45d Gerrit-Change-Number: 17127 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 03:00:25 +0000 Gerrit-HasComments: Yes
