Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17114 )
Change subject: test: add more natural test for KUDU-2233 ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17114/2/src/kudu/tablet/compaction.cc File src/kudu/tablet/compaction.cc: http://gerrit.cloudera.org:8080/#/c/17114/2/src/kudu/tablet/compaction.cc@77 PS2, Line 77: DEFINE_bool(dcheck_on_kudu_2233_invariants, true > I can surround this with some ifndef sure, but we do have several test-only Yes, this one different as I can see: it's not quite used in NDEBUG case, while other test-only flags are used in both debug and NDEBUG case. At lines 308-311 and 316-319 the usage of this flag reduces to an empty if() clause in NDEBUG mode. Why to keep such a flag then in NDEBUG case? -- To view, visit http://gerrit.cloudera.org:8080/17114 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icac3ad0a1b6bb9b17d5b6a901dc5bba79c0840fa Gerrit-Change-Number: 17114 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 26 Feb 2021 16:56:12 +0000 Gerrit-HasComments: Yes
