Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17143 )
Change subject: [KUDU-3252] a test to reproduce the issue KUDU-3252 ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager-test.cc@1206 PS1, Line 1206: threads.emplace_back([fsManager]() { Consider using the Barrier primitive to synchronize the start of the threads. For an example, you could check TEST_F(ClientTest, TestRetrieveAuthzTokenInParallel) test scenario in src/kudu/client/client-test.cc http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager-test.cc@1207 PS1, Line 1207: fsManager->CreateInitialFileSystemLayout(); This call returns result status. Does it make sense to capture the result per-thread and check it after joining the threads? http://gerrit.cloudera.org:8080/#/c/17143/1/src/kudu/fs/fs_manager.cc File src/kudu/fs/fs_manager.cc: PS1: Did you find these logging changes helpful if looking beyond the scope of the newly added test scenario? -- To view, visit http://gerrit.cloudera.org:8080/17143 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90af630ec0a6917b83bcd16e14c59b5300f770b7 Gerrit-Change-Number: 17143 Gerrit-PatchSet: 1 Gerrit-Owner: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 06 Mar 2021 17:48:51 +0000 Gerrit-HasComments: Yes
