Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17152 )
Change subject: KUDU-3254 fix bug in meta-cache exposed by KUDU-1802 ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Thanks for the fix and test. This test should also be added to master right? It looks like there are test failures due to unrelated python infra issues on the branch. http://gerrit.cloudera.org:8080/#/c/17152/6/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/17152/6/src/kudu/client/meta_cache.cc@932 PS6, Line 932: if (remote.get() != nullptr) { Ah, so this issue only exists if a range partition was dropped and then replaced with a new range that overlaps the dropped range or replaces the dropped range? http://gerrit.cloudera.org:8080/#/c/17152/6/src/kudu/client/meta_cache.cc@943 PS6, Line 943: auto* entry = FindOrNull(tablets_by_key, tablet_lower_bound); Might be a good idea to audit the codebase for other usages of FindOrDie. We probably don't want that anywhere for production code if possible. Not related specifically to this pass just a passing comment. -- To view, visit http://gerrit.cloudera.org:8080/17152 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.13.x Gerrit-MessageType: comment Gerrit-Change-Id: I5b8370290c13b1e496f461ed5bc2e0193bdf4b19 Gerrit-Change-Number: 17152 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 06 Mar 2021 22:51:27 +0000 Gerrit-HasComments: Yes
