Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17160 )
Change subject: [docs] update build instructions to run on SLES 15 ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc File docs/installation.adoc: http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@413 PS1, Line 413: $ CC=gcc-8 CXX=g++-8 ctest -R "client_examples-test*" > Won't `build-support/enable_devtoolset.sh` handle this? I guess it helps if running tests in the same shell session or a descendant one. Probably, that's what expected :) Well, let's assume so. Done. http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@522 PS1, Line 522: java-11-openjdk-devel > Is it still possible to use Java 8 for sles 15? All of our other builds sti It is: Java 8 is in legacy module, but it's available. Done. http://gerrit.cloudera.org:8080/#/c/17160/1/docs/installation.adoc@525 PS1, Line 525: export CC_FOR_BUILD=gcc-8 > Can we add this to build-support/enable_devtoolset.sh if it's needed? Yep, that looks like a good option. Those xxx_FOR_BUILD variables are specific to protobuf, all other components are able to find those based on CC/CXX settings. Probably, the better way is patching protobuf config scripts to do proper thing. I'll add this into the script and add corresponding TODO along. -- To view, visit http://gerrit.cloudera.org:8080/17160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I126d9d70288931ace6f6534c3b4f768b7dee17b1 Gerrit-Change-Number: 17160 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 08 Mar 2021 19:45:59 +0000 Gerrit-HasComments: Yes
