Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17163 )

Change subject: KUDU-3207 Switch RSA private key format to PKCS#8
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17163/2/src/kudu/security/test/test_certs.cc
File src/kudu/security/test/test_certs.cc:

PS2:
If anything changed w.r.t. how to get these keys with their current format?  If 
yes, could you add corresponding blurb in the comment for kCaCert or around?  
That might help when adding new keys in future.



--
To view, visit http://gerrit.cloudera.org:8080/17163
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie46fd4f0b8bafcbe606a444e31c9af9e09291e64
Gerrit-Change-Number: 17163
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 09 Mar 2021 16:36:19 +0000
Gerrit-HasComments: Yes

Reply via email to