Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17161 )
Change subject: KUDU-2671: No-op ClientServerMapping if only one schema exists. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17161/2/src/kudu/common/row_operations.cc File src/kudu/common/row_operations.cc: http://gerrit.cloudera.org:8080/#/c/17161/2/src/kudu/common/row_operations.cc@682 PS2, Line 682: if (client_schema_ != tablet_schema_) { : RETURN_NOT_OK(client_schema_->GetProjectionMapping(*tablet_schema_, &mapping)); : DCHECK_EQ(mapping.num_mapped(), client_schema_->num_columns( > nit: how about instead we just put this into the if block below? Then we wo Done -- To view, visit http://gerrit.cloudera.org:8080/17161 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I836f157201509a9b38a3ad42d653236f240dda5e Gerrit-Change-Number: 17161 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 09 Mar 2021 21:50:47 +0000 Gerrit-HasComments: Yes
