Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/17198 )
Change subject: [security] enhance tls_handshake test
......................................................................
[security] enhance tls_handshake test
This patch adds extra verification step into the TestHandshakeSequence
scenario of TestTlsHandshake. That's to assert that both parties can
send and receive application data using OpenSSL API (i.e. SSL_Read() and
SSL_Write() function) once TlsHandshake::Continue() returns Status::OK.
In addition, the newly introduced utility methods in TestTlsHandshake
are useful for a follow-up changelist as well.
In addition, I cleaned up code in {client,server}_negotiation.cc
and in tls_context.cc.
Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Reviewed-on: http://gerrit.cloudera.org:8080/17198
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <[email protected]>
Reviewed-by: Attila Bukor <[email protected]>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_context.cc
M src/kudu/security/tls_handshake-test.cc
M src/kudu/security/tls_handshake.h
5 files changed, 98 insertions(+), 20 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, but someone else must approve
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17198
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie77d1f35e12fe74be9f4022e8cd7087500052743
Gerrit-Change-Number: 17198
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
