Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17189 )
Change subject: KUDU-2871 support TLSv1.3 in Kudu RPC (C++ part) ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/17189/2/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: http://gerrit.cloudera.org:8080/#/c/17189/2/src/kudu/rpc/server_negotiation.cc@614 PS2, Line 614: if (!needs_extra_step && !token.empty()) { > warning: 'token' used after it was moved [bugprone-use-after-move] This is bogus: 'token' was not moved if 'needs_extra_step' evaluates to 'false'. http://gerrit.cloudera.org:8080/#/c/17189/2/src/kudu/security/tls_context.cc File src/kudu/security/tls_context.cc: http://gerrit.cloudera.org:8080/#/c/17189/2/src/kudu/security/tls_context.cc@117 PS2, Line 117: constexpr const char* const kTLSv1_1 = "TLSv1.1"; > warning: invalid case style for global constant 'kTLSv1_1' [readability-ide kKTlSv11 instead of kTLSv1_1 ? No, thank you :) http://gerrit.cloudera.org:8080/#/c/17189/2/src/kudu/security/tls_context.cc@118 PS2, Line 118: constexpr const char* const kTLSv1_2 = "TLSv1.2"; > warning: invalid case style for global constant 'kTLSv1_2' [readability-ide ditto http://gerrit.cloudera.org:8080/#/c/17189/2/src/kudu/security/tls_context.cc@119 PS2, Line 119: constexpr const char* const kTLSv1_3 = "TLSv1.3"; > warning: invalid case style for global constant 'kTLSv1_3' [readability-ide ditto -- To view, visit http://gerrit.cloudera.org:8080/17189 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia92a4d102c3c8cff76101e71ff71d24a9d78b672 Gerrit-Change-Number: 17189 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 19 Mar 2021 18:42:13 +0000 Gerrit-HasComments: Yes
